linux-kernel - Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 18:57:04 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, xinlei.lee@...iatek.com,
        lee.jones@...aro.org, robh+dt@...nel.org, matthias.bgg@...il.com,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, rex-bc.chen@...iatek.com,
        jitao.shi@...iatek.com,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for
 MediaTek MT8192

On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 18/04/22 14:20, xinlei.lee@...iatek.com ha scritto:
> > > From: Xinlei Lee <xinlei.lee@...iatek.com>
> > > 
> > > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > > 
> > > Signed-off-by: Xinlei Lee <xinlei.lee@...iatek.com>
> > 
> > Hello Xinlei,
> > the pwm-mtk-disp.c driver does not support interrupts.
> > 
> > Please add interrupts support to the driver first, and only then
> > add that in the dt-bindings.
> 
> in my understanding the linux driver state and the binding documentation
> are somewhat independent. Here I'd say adding the irq information to dt
> without the driver supporting it is fine.

Agreed. I've applied this along with the rest. It doesn't have Rob's or
Krzysztof's stamp of approval, but it's a trivial change and looks fine
to me.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)