linux-kernel - Re: [PATCH V1 1/1] scripts/Kbuild: Add path of fixeddep script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Apr 2022 02:55:28 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Laxman Dewangan <ldewangan@...dia.com>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1 1/1] scripts/Kbuild: Add path of fixeddep script

On Fri, Apr 22, 2022 at 6:05 PM Laxman Dewangan <ldewangan@...dia.com> wrote:
>
> Add path of the fixdep script from the object tree.
> This will make the path of script absolute rather than
> relative and execute the command from makefile from any
> location.



Why is this necessary?

Also, this patch does not make anything.
$(objtree)/ is still a relative path.
See the top Makefile.



>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>  scripts/Kbuild.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index cdec22088423e..e07e9265829f8 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -147,7 +147,7 @@ if_changed_dep = $(if $(if-changed-cond),$(cmd_and_fixdep),@:)
>
>  cmd_and_fixdep =                                                             \
>         $(cmd);                                                              \
> -       scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
> +       $(objtree)/scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
>         rm -f $(depfile)
>
>  # Usage: $(call if_changed_rule,foo)
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada