linux-kernel - Re: [PATCH v3 5/7] mm: demotion: Build demotion list based on N_DEMOTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAPL-u9yxX=DyYHeS-DS=S47JfW9CQmKmdRLYFOv49C-XSwgCw@mail.gmail.com>
Date:   Fri, 22 Apr 2022 13:39:07 -0700
From:   Wei Xu <weixugc@...gle.com>
To:     Jagdish Gediya <jvgediya@...ux.ibm.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, baolin.wang@...ux.alibaba.com,
        dave.hansen@...ux.intel.com, ying.huang@...el.com,
        aneesh.kumar@...ux.ibm.com, shy828301@...il.com,
        gthelen@...gle.com, dan.j.williams@...el.com
Subject: Re: [PATCH v3 5/7] mm: demotion: Build demotion list based on N_DEMOTION_TARGETS

On Fri, Apr 22, 2022 at 12:55 PM Jagdish Gediya <jvgediya@...ux.ibm.com> wrote:
>
> Only nodes which has state N_DEMOTION_TARGETS should be
> used as demotion targets, make nodes which are not in demotion
> targets as source nodes while building demotion target list
> so that demotion targets are only chosen from N_DEMOTION_TARGETS.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>
> Signed-off-by: Jagdish Gediya <jvgediya@...ux.ibm.com>
> ---

Acked-by: Wei Xu <weixugc@...gle.com>

>  mm/migrate.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 8bbe1e478122..5b92a09fbe4a 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2366,10 +2366,10 @@ static void __set_migration_target_nodes(void)
>         disable_all_migrate_targets();
>
>         /*
> -        * Allocations go close to CPUs, first.  Assume that
> -        * the migration path starts at the nodes with CPUs.
> +        * Some systems can have DRAM(fast memory) only NUMA nodes, demotion targets
> +        * need to be found for them as well.
>          */
> -       next_pass = node_states[N_CPU];
> +       nodes_andnot(next_pass, node_states[N_ONLINE], node_states[N_DEMOTION_TARGETS]);
>  again:
>         this_pass = next_pass;
>         next_pass = NODE_MASK_NONE;
> --
> 2.35.1
>