linux-kernel - Re: [PATCH for-5.18] KVM: fix bad user ABI for KVM_EXIT_SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204230312.8EOM8DHM-lkp@intel.com>
Date:   Sat, 23 Apr 2022 03:57:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Will Deacon <will@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Peter Gonda <pgonda@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH for-5.18] KVM: fix bad user ABI for KVM_EXIT_SYSTEM_EVENT

Hi Paolo,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/master]
[also build test ERROR on linus/master v5.18-rc3]
[cannot apply to kvmarm/next mst-vhost/linux-next linux/master next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Paolo-Bonzini/KVM-fix-bad-user-ABI-for-KVM_EXIT_SYSTEM_EVENT/20220422-184535
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
config: riscv-randconfig-r014-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230312.8EOM8DHM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/71af2c55b700878ad9d73c90c6b75f327f36d0a9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Paolo-Bonzini/KVM-fix-bad-user-ABI-for-KVM_EXIT_SYSTEM_EVENT/20220422-184535
        git checkout 71af2c55b700878ad9d73c90c6b75f327f36d0a9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/riscv/kvm/vcpu_sbi.c:98:30: error: use of undeclared identifier 'reason'
           run->system_event.data[0] = reason;
                                       ^
   1 error generated.


vim +/reason +98 arch/riscv/kvm/vcpu_sbi.c

    83	
    84	void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,
    85					     struct kvm_run *run,
    86					     u32 type, u64 flags)
    87	{
    88		unsigned long i;
    89		struct kvm_vcpu *tmp;
    90	
    91		kvm_for_each_vcpu(i, tmp, vcpu->kvm)
    92			tmp->arch.power_off = true;
    93		kvm_make_all_cpus_request(vcpu->kvm, KVM_REQ_SLEEP);
    94	
    95		memset(&run->system_event, 0, sizeof(run->system_event));
    96		run->system_event.type = type;
    97		run->system_event.ndata = 1;
  > 98		run->system_event.data[0] = reason;
    99		run->exit_reason = KVM_EXIT_SYSTEM_EVENT;
   100	}
   101	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp