linux-kernel - Re: [PATCH 2/2] thermal: sun8i: add R329 THS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a80fa962ac4a852b599ccf8e383e43e8eea7d12e.camel@aosc.io>
Date:   Sat, 23 Apr 2022 07:41:51 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Samuel Holland <samuel@...lland.org>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>
Cc:     linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] thermal: sun8i: add R329 THS

在 2022-04-22星期五的 18:39 -0500，Samuel Holland写道：
> Hi Icenowy,
> 
> On 4/22/22 11:11 AM, icenowy@...look.com wrote:
> > From: Icenowy Zheng <icenowy@...c.io>
> > 
> > The thermal sensor controller on R329 is similar to the one on H6,
> > but
> > with only one sensor. Calibration method is still unknown because
> > no
> > calibration is implemented in BSP kernel, neither is it documented
> > in
> > the user manual.
> 
> Looking at the BSP smartx-r329-tina-for-jishu-community-v0.2, I see:
> 
> ths_calib: calib@14 {
>         reg = <0x14 4>;
> };
> 
> And the BSP driver (drivers/thermal/sunxi_thermal-ng.c) claims that
> R329 uses
> the same calibration method as for H616. Maybe you are looking at an
> older BSP?

Yes. All these r329 work is done the last year during my internship at
Sipeed.

I will check the newer version of BSP and if okay I will add the
calibrate routine in the next revision.

> 
> Regards,
> Samuel
> 
> > 
> > Add its support to sun8i-thermal driver. Calibrating it is now
> > prevented.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> > ---
> >  drivers/thermal/sun8i_thermal.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thermal/sun8i_thermal.c
> > b/drivers/thermal/sun8i_thermal.c
> > index d9cd23cbb671..3a2f381005b4 100644
> > --- a/drivers/thermal/sun8i_thermal.c
> > +++ b/drivers/thermal/sun8i_thermal.c
> > @@ -312,7 +312,8 @@ static int sun8i_ths_calibrate(struct
> > ths_device *tmdev)
> >                 goto out;
> >         }
> >  
> > -       tmdev->chip->calibrate(tmdev, caldata, callen);
> > +       if (tmdev->chip->calibrate)
> > +               tmdev->chip->calibrate(tmdev, caldata, callen);
> >  
> >         kfree(caldata);
> >  out:
> > @@ -628,6 +629,17 @@ static const struct ths_thermal_chip
> > sun50i_h6_ths = {
> >         .calc_temp = sun8i_ths_calc_temp,
> >  };
> >  
> > +static const struct ths_thermal_chip sun50i_r329_ths = {
> > +       .sensor_num = 1,
> > +       .has_bus_clk_reset = true,
> > +       .offset = 188744,
> > +       .scale = 672,
> > +       .temp_data_base = SUN50I_H6_THS_TEMP_DATA,
> > +       .init = sun50i_h6_thermal_init,
> > +       .irq_ack = sun50i_h6_irq_ack,
> > +       .calc_temp = sun8i_ths_calc_temp,
> > +};
> > +
> >  static const struct of_device_id of_ths_match[] = {
> >         { .compatible = "allwinner,sun8i-a83t-ths", .data =
> > &sun8i_a83t_ths },
> >         { .compatible = "allwinner,sun8i-h3-ths", .data =
> > &sun8i_h3_ths },
> > @@ -636,6 +648,7 @@ static const struct of_device_id of_ths_match[]
> > = {
> >         { .compatible = "allwinner,sun50i-a100-ths", .data =
> > &sun50i_a100_ths },
> >         { .compatible = "allwinner,sun50i-h5-ths", .data =
> > &sun50i_h5_ths },
> >         { .compatible = "allwinner,sun50i-h6-ths", .data =
> > &sun50i_h6_ths },
> > +       { .compatible = "allwinner,sun50i-r329-ths", .data =
> > &sun50i_r329_ths },
> >         { /* sentinel */ },
> >  };
> >  MODULE_DEVICE_TABLE(of, of_ths_match);
> > 
> 
>