linux-kernel - Re: [PATCH] serial: sunplus-uart: change sunplus_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 07:18:22 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Tom Rix <trix@...hat.com>, hammerh0314@...il.com,
        gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: sunplus-uart: change sunplus_console_ports from
 global to static

On 21. 04. 22, 17:25, Tom Rix wrote:
> Smatch reports this issue
> sunplus-uart.c:501:26: warning: symbol 'sunplus_console_ports' was not declared. Should it be static?
> 
> sunplus_console_ports is only used in sunplus-uart.c so change
> its storage-class specifier to static

Heh, coincidentally, I've sent the same fix yesterday too:
https://lore.kernel.org/all/20220421101708.5640-2-jslaby@suse.cz/

Greg, whichever you take:
Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/tty/serial/sunplus-uart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sunplus-uart.c b/drivers/tty/serial/sunplus-uart.c
> index 9f15922e681b..60c73662f955 100644
> --- a/drivers/tty/serial/sunplus-uart.c
> +++ b/drivers/tty/serial/sunplus-uart.c
> @@ -498,7 +498,7 @@ static const struct uart_ops sunplus_uart_ops = {
>   };
>   
>   #ifdef CONFIG_SERIAL_SUNPLUS_CONSOLE
> -struct sunplus_uart_port *sunplus_console_ports[SUP_UART_NR];
> +static struct sunplus_uart_port *sunplus_console_ports[SUP_UART_NR];
>   
>   static void sunplus_uart_console_putchar(struct uart_port *port,
>   					 unsigned char ch)


-- 
js
suse labs