linux-kernel - Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 09:03:59 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Rex-BC Chen <rex-bc.chen@...iatek.com>,
        "Nícolas F. R. A. Prado" <nfraprado@...labora.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, <kernel@...labora.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jitao Shi <jitao.shi@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <dri-devel@...ts.freedesktop.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for
 mt8192

Hi,

On Wed, 2022-04-20 at 20:23 +0800, Rex-BC Chen wrote:
> On Thu, 2022-04-07 at 21:39 -0400, Nícolas F. R. A. Prado wrote:
> > The configuration for mt8192 was incorrectly using the output
> > formats
> > from mt8173. Since the output formats for mt8192 are instead the
> > same
> > ones as for mt8183, which require two bus samples per pixel, the
> > pixelclock and DDR edge setting were misconfigured. This made
> > external
> > displays unable to show the image.
> > 
> > Fix the issue by correcting the output format for mt8192 to be the
> > same
> > as for mt8183, fixing the usage of external displays for mt8192.
> > 
> > Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to
> > driver data")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > ---
> > 
> > Changes in v2:
> > - Added Fixes tag
> > 
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..e61cd67b978f 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.cal_factor = mt8183_calculate_factor,
> >  	.reg_h_fre_con = 0xe0,
> >  	.max_clock_khz = 150000,
> > -	.output_fmts = mt8173_output_fmts,
> > -	.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > +	.output_fmts = mt8183_output_fmts,
> > +	.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> >  };
> >  
> >  static int mtk_dpi_probe(struct platform_device *pdev)
> 
> Reviewed-by: Rex-BC Chen <rex-bc.chen@...iatek.com>
> 
> Hello CK,
> 
> Gentle ping for this patch.
> This patch is confirmed by Xinlei and Jitao.

Applied to mediatek-drm-next [1].

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
CK

> 
> BRs,
> Rex
>