linux-kernel - Re:Re: [PATCH] net/wireless: add debugfs exit function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c0443f.3b82.1804ffdcdeb.Coremail.zhaojunkui2008@126.com>
Date:   Fri, 22 Apr 2022 14:37:55 +0800 (CST)
From:   z <zhaojunkui2008@....com>
To:     "Kalle Valo" <kvalo@...nel.org>
Cc:     "Jakub Kicinski" <kubakici@...pl>,
        "David S. Miller" <davem@...emloft.net>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        bernard@...o.com
Subject: Re:Re: [PATCH] net/wireless: add debugfs exit function

Hi Kalle Valo:

>-----邮件原件-----
>发件人: Kalle Valo <kvalo@...nel.org> 
>发送时间: 2022年4月22日 13:57
>收件人: Bernard Zhao <zhaojunkui2008@....com>
>抄送: Jakub Kicinski <kubakici@...pl>; David S. Miller <davem@...emloft.net>; Paolo Abeni <pabeni@...hat.com>; Matthias Brugger <matthias.bgg@...il.com>; linux-wireless@...r.kernel.org; netdev@...r.kernel.org; >linux-arm-kernel@...ts.infradead.org; linux-mediatek@...ts.infradead.org; linux-kernel@...r.kernel.org; 赵军奎 <bernard@...o.com>
>主题: Re: [PATCH] net/wireless: add debugfs exit function

>Bernard Zhao <zhaojunkui2008@....com> writes:

>> This patch add exit debugfs function to mt7601u.
>> Debugfs need to be cleanup when module is unloaded or load fail.

>"load fail"? Please be more specific, are you saying that the second module load fails or what?
For this part, there are two cases:
First when mt7601u is loaded, in function mt7601u_probe, if function mt7601u_probe run into error lable err_hw, mt7601u_cleanup didn`t cleanup the debugfs node.
Second when the module disconnect, in function mt7601u_disconnect, mt7601u_cleanup didn`t cleanup the debugfs node.
I think these are the mt7601u unloaded or load fail cases, but both with no debugfs cleanup work.

>>  drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
>>  drivers/net/wireless/mediatek/mt7601u/init.c    | 1 +
>>  drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +

>The title should be:

>mt7601u: add debugfs exit function
Got it, thanks！

>> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
>> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
>> @@ -9,6 +9,8 @@
>>  #include "mt7601u.h"
>>  #include "eeprom.h"
>>  
>> +static struct dentry *dir;

>How will this work when there are multiple mt7601u devices? Because of that, avoid using non-const static variables.
Sorry for missing this part, I understand that the better way is to manage it in the struct of the matched device, I would fix this in the next patch.
Thank you very much!

BR//Bernard

>--
>https://patchwork.kernel.org/project/linux-wireless/list/

>https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches