linux-kernel - drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:88:14: warning: variable 'is_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 16:56:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alex Deucher <alexander.deucher@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Zhan Liu <zhan.liu@....com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:88:14:
 warning: variable 'is_in_uma' set but not used

Hi Alex,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d569e86915b7f2f9795588591c8d5ea0b66481cb
commit: 519607a2f7798decb9c891a4f706aaf780f5a677 drm/amdgpu/display: fold DRM_AMD_DC_DCN201 into DRM_AMD_DC_DCN
date:   7 months ago
config: powerpc64-randconfig-r033-20220420 (https://download.01.org/0day-ci/archive/20220422/202204221604.l3cM1i38-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=519607a2f7798decb9c891a4f706aaf780f5a677
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 519607a2f7798decb9c891a4f706aaf780f5a677
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c: In function 'gpu_addr_to_uma':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:88:14: warning: variable 'is_in_uma' set but not used [-Wunused-but-set-variable]
      88 |         bool is_in_uma;
         |              ^~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c: In function 'dcn201_pipe_control_lock':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:544:22: warning: variable 'hubp' set but not used [-Wunused-but-set-variable]
     544 |         struct hubp *hubp = NULL;
         |                      ^~~~
--
   drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_dpp.c: In function 'dpp201_get_optimal_number_of_taps':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_dpp.c:185:18: warning: variable 'pixel_width' set but not used [-Wunused-but-set-variable]
     185 |         uint32_t pixel_width;
         |                  ^~~~~~~~~~~


vim +/is_in_uma +88 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c

3f68c01be9a222 Zhan Liu 2021-09-25   84  
3f68c01be9a222 Zhan Liu 2021-09-25   85  static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
3f68c01be9a222 Zhan Liu 2021-09-25   86  		PHYSICAL_ADDRESS_LOC *addr)
3f68c01be9a222 Zhan Liu 2021-09-25   87  {
3f68c01be9a222 Zhan Liu 2021-09-25  @88  	bool is_in_uma;
3f68c01be9a222 Zhan Liu 2021-09-25   89  
3f68c01be9a222 Zhan Liu 2021-09-25   90  	if (hwseq->fb_base.quad_part <= addr->quad_part &&
3f68c01be9a222 Zhan Liu 2021-09-25   91  			addr->quad_part < hwseq->fb_top.quad_part) {
3f68c01be9a222 Zhan Liu 2021-09-25   92  		addr->quad_part -= hwseq->fb_base.quad_part;
3f68c01be9a222 Zhan Liu 2021-09-25   93  		addr->quad_part += hwseq->fb_offset.quad_part;
3f68c01be9a222 Zhan Liu 2021-09-25   94  		is_in_uma = true;
3f68c01be9a222 Zhan Liu 2021-09-25   95  	} else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
3f68c01be9a222 Zhan Liu 2021-09-25   96  			addr->quad_part <= hwseq->uma_top.quad_part) {
3f68c01be9a222 Zhan Liu 2021-09-25   97  		is_in_uma = true;
3f68c01be9a222 Zhan Liu 2021-09-25   98  	} else if (addr->quad_part == 0) {
3f68c01be9a222 Zhan Liu 2021-09-25   99  		is_in_uma = false;
3f68c01be9a222 Zhan Liu 2021-09-25  100  	} else {
3f68c01be9a222 Zhan Liu 2021-09-25  101  		is_in_uma = false;
3f68c01be9a222 Zhan Liu 2021-09-25  102  	}
3f68c01be9a222 Zhan Liu 2021-09-25  103  }
3f68c01be9a222 Zhan Liu 2021-09-25  104  

:::::: The code at line 88 was first introduced by commit
:::::: 3f68c01be9a2227de1e190317fe34a6fb835a094 drm/amd/display: add cyan_skillfish display support

:::::: TO: Zhan Liu <zhan.liu@....com>
:::::: CC: Alex Deucher <alexander.deucher@....com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp