linux-kernel - Re: [PATCH v1] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ERR_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1D02DBF7-9368-43D5-9062-96CC73E22B57@holtmann.org>
Date:   Fri, 22 Apr 2022 11:17:11 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Zijun Hu <quic_zijuhu@...cinc.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, c-hbandi@...eaurora.org,
        hemantg@...eaurora.org, rjliao@...eaurora.org,
        zijuhu@...eaurora.org, tjiang@...eaurora.org
Subject: Re: [PATCH v1] Bluetooth: btusb: Set
 HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA

Hi Zijun,

> Set HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA controllers since
> they answer HCI_OP_READ_DEF_ERR_DATA_REPORTING with error code
> "UNKNOWN HCI COMMAND" as shown below:
> 
> [  580.517552] Bluetooth: hci0: unexpected cc 0x0c5a length: 1 < 2
> [  580.517660] Bluetooth: hci0: Opcode 0x c5a failed: -38
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 06a854a2507e..a33f8705f147 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3340,6 +3340,8 @@ static int btusb_setup_qca(struct hci_dev *hdev)
> 	 */
> 	set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks);
> 
> +	set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks);
> +
> 	return 0;
> }

please include the supported commands output from btmon that indicates that this hardware declares support for this command.

Regards

Marcel