linux-kernel - Re: [PATCH] x86/tdx: Annotate a noreturn function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220422021342.wpxpubqan6ndsajx@black.fi.intel.com>
Date:   Fri, 22 Apr 2022 05:13:42 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/tdx: Annotate a noreturn function

On Wed, Apr 20, 2022 at 01:50:25PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> objdump complains:
> 
>   vmlinux.o: warning: objtool: __tdx_hypercall()+0x74: unreachable instruction
> 
> because __tdx_hypercall_failed() won't return but panic the guest.
> Annotate that that is ok and desired.
> 
> Fixes: eb94f1b6a70a ("x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions")
> Signed-off-by: Borislav Petkov <bp@...e.de>

Have not seen REACHABLE before.

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov