linux-kernel - Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8016b196-6a39-8808-b1ff-286aacb2c8ca@redhat.com>
Date:   Fri, 22 Apr 2022 04:36:34 -0700
From:   Tom Rix <trix@...hat.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to
 variable 'end'


On 4/22/22 4:04 AM, Colin Ian King wrote:
> Variable end is being initialized with a value that is never read, it
> is being re-assigned later with the same value. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> kernel/irq/matrix.c:289:25: warning: Value stored to 'end' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   kernel/irq/matrix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
> index bbfb26489aa1..1698e77645ac 100644
> --- a/kernel/irq/matrix.c
> +++ b/kernel/irq/matrix.c
> @@ -286,7 +286,7 @@ void irq_matrix_remove_managed(struct irq_matrix *m, const struct cpumask *msk)
>   int irq_matrix_alloc_managed(struct irq_matrix *m, const struct cpumask *msk,
>   			     unsigned int *mapped_cpu)
>   {
> -	unsigned int bit, cpu, end = m->alloc_end;
> +	unsigned int bit, cpu, end;
Reviewed-by: Tom Rix <trix@...hat.com>
>   	struct cpumap *cm;
>   
>   	if (cpumask_empty(msk))