linux-kernel - Re: [PATCH] USB2NET : SR9800 : change SR9800_BULKIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165062821159.27289.12403848172811597562.git-patchwork-notify@kernel.org>
Date:   Fri, 22 Apr 2022 11:50:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Tom Rix <trix@...hat.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to
 static

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@...emloft.net>:

On Tue, 19 Apr 2022 10:06:25 -0400 you wrote:
> Smatch reports this issue
> sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?
> 
> Global variables should not be defined in header files.
> This only works because sr9800.h in only included by sr9800.c
> Change the storage-class specifier to static.
> And since it does not change add type qualifier const.
> 
> [...]

Here is the summary with links:
  - USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
    https://git.kernel.org/netdev/net-next/c/0844d36f771d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html