linux-kernel - Re: [PATCH] mm: do not call add_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmIUvdjSlRD6udQg@carbon>
Date:   Thu, 21 Apr 2022 19:36:45 -0700
From:   Roman Gushchin <roman.gushchin@...ux.dev>
To:     Dave Chinner <dchinner@...hat.com>
Cc:     David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Yang Shi <shy828301@...il.com>
Subject: Re: [PATCH] mm: do not call add_nr_deferred() with zero deferred

On Fri, Apr 22, 2022 at 11:19:05AM +1000, Dave Chinner wrote:
> On Tue, Apr 19, 2022 at 09:42:30AM -0700, Roman Gushchin wrote:
> > On Tue, Apr 19, 2022 at 02:56:06PM +0200, David Hildenbrand wrote:
> > > On 16.04.22 02:41, Roman Gushchin wrote:
> > > > add_nr_deferred() is often called with next_deferred equal to 0.
> > > > For instance, it's happening under low memory pressure for any
> > > > shrinkers with a low number of cached objects. A corresponding trace
> > > > looks like:
> > > >   <...>-619914 [005] .... 467456.345160: mm_shrink_slab_end: \
> > > >   super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1	     \
> > > >   unused scan count 0 new scan count 0 total_scan 0	     \
> > > >   last shrinker return val 0
> > > > 
> > > >   <...>-619914 [005] .... 467456.345371: mm_shrink_slab_end: \
> > > >   super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1	     \
> > > >   unused scan count 0 new scan count 0 total_scan 0	     \
> > > >   last shrinker return val 0
> > > > 
> > > >   <...>-619914 [005] .... 467456.345380: mm_shrink_slab_end: \
> > > >   super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 unused \
> > > >   scan count 0 new scan count 0 total_scan 0	             \
> > > >   last shrinker return val 0
> > > > 
> > > > This lead to unnecessary checks and atomic operations, which can be
> > > > avoided by checking next_deferred for not being zero before calling
> > > > add_nr_deferred(). In this case the mm_shrink_slab_end trace point
> > > > will get a potentially slightly outdated "new scan count" value, but
> > > > it's totally fine.
> > > 
> > > Sufficient improvement to justify added complexity for anybody reading
> > > that code?
> > 
> > I don't have any numbers and really doubt the difference is significant,
> 
> Never been able to measure it myself.
> 
> HwoeverI'd much prefer the tracepoint output stays accurate - I've had to
> post-process and/or graph the shrinker progress as reported by the
> start/end tracpoints to find problems in the algorithms in the past.
> That's why there is the additional complexity in the code to make
> sure the coutners are accurate in the first place.

Sure, no problems.

Andrew, can you, please, drop this patch?

Thanks!