linux-kernel - Re: [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 14:59:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Xiaomeng Tong <xiam0nd.tong@...il.com>
Cc:     balbi@...nel.org, michal.simek@...inx.com,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: udc-xilinx: remove unnecessary
 initialization of list iterator

On Wed, Mar 16, 2022 at 03:51:53PM +0800, Xiaomeng Tong wrote:
> 'req' will always be set by the subsequent list_for_each_entry()
> before any uses. Thus, to avoid ambiguity it is better to remove
> the unnecessary initialization of list iterator 'req'.
> 
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@...il.com>
> ---
>  drivers/usb/gadget/udc/udc-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
> index 6ce886fb7..fa6cbfc63 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -1136,7 +1136,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
>  static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>  {
>  	struct xusb_ep *ep	= to_xusb_ep(_ep);
> -	struct xusb_req *req	= to_xusb_req(_req);
> +	struct xusb_req *req;
>  	struct xusb_udc *udc	= ep->udc;
>  	unsigned long flags;
>  
> -- 
> 2.17.1
> 

Does not apply anymore :(