linux-kernel - Re: [PATCH] powercap/dtpm: move dtpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ivfLtbEL2h1ivATmTTE0+AxWXeZnbCrfF8R=Y-7rfkcA@mail.gmail.com>
Date:   Fri, 22 Apr 2022 15:56:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tom Rix <trix@...hat.com>,
        Daniel Lezcano <daniel.lezcano@...nel.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powercap/dtpm: move dtpm_subsys definition to dtpm.c

On Mon, Apr 18, 2022 at 8:08 PM Tom Rix <trix@...hat.com> wrote:
>
> Smatch reports this issue
> dtpm_devfreq.c:200:24: warning: symbol 'dtpm_devfreq_ops'
>   was not declared. Should it be static?
>
> dtpm_devfreq_ops is declared in dtpm_subsys.h where it
> is also used
>
> extern struct dtpm_subsys_ops dtpm_devfreq_ops;
> struct dtpm_subsys_ops *dtpm_subsys[] = {
> ...
>         &dtpm_devfreq_ops,
>
> Global variables should not be defined in header files.
> This only works because dtpm.c is the only includer
> of dtpm_subsys.h and user of dtpm_susys[].
>
> Move the definition of dtpm_subsys[] to dtpm.c and change
> the storage-class specifier to static.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Daniel, any comments?

Or do you want to pick it up yourself?

> ---
>  drivers/powercap/dtpm.c        | 9 +++++++++
>  drivers/powercap/dtpm_subsys.h | 9 ---------
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index ce920f17f45f..827a2509bec7 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -29,6 +29,15 @@
>
>  #define DTPM_POWER_LIMIT_FLAG 0
>
> +static struct dtpm_subsys_ops *dtpm_subsys[] = {
> +#ifdef CONFIG_DTPM_CPU
> +       &dtpm_cpu_ops,
> +#endif
> +#ifdef CONFIG_DTPM_DEVFREQ
> +       &dtpm_devfreq_ops,
> +#endif
> +};
> +
>  static const char *constraint_name[] = {
>         "Instantaneous",
>  };
> diff --git a/drivers/powercap/dtpm_subsys.h b/drivers/powercap/dtpm_subsys.h
> index db1712938a96..2db9a3efba93 100644
> --- a/drivers/powercap/dtpm_subsys.h
> +++ b/drivers/powercap/dtpm_subsys.h
> @@ -10,13 +10,4 @@
>  extern struct dtpm_subsys_ops dtpm_cpu_ops;
>  extern struct dtpm_subsys_ops dtpm_devfreq_ops;
>
> -struct dtpm_subsys_ops *dtpm_subsys[] = {
> -#ifdef CONFIG_DTPM_CPU
> -       &dtpm_cpu_ops,
> -#endif
> -#ifdef CONFIG_DTPM_DEVFREQ
> -       &dtpm_devfreq_ops,
> -#endif
> -};
> -
>  #endif
> --
> 2.27.0
>