linux-kernel - Re: [PATCH] media: m920x: Remove useless kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165063734898.3204481.2637889109438003078@Monstersaurus>
Date:   Fri, 22 Apr 2022 15:22:28 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Haowen Bai <baihaowen@...zu.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Haowen Bai <baihaowen@...zu.com>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: m920x: Remove useless kfree

Quoting Haowen Bai (2022-04-22 07:06:47)
> After alloc fail, we do not need to kfree.
> 

Agreed, this shouldn't hurt as kfree will be a noop here but it is
always null so redundant.

May still warrant a fixes tag though, but it's not a critical fix.


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/media/usb/dvb-usb/m920x.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-usb/m920x.c
> index 548199cd86f6..9df0ccfb654b 100644
> --- a/drivers/media/usb/dvb-usb/m920x.c
> +++ b/drivers/media/usb/dvb-usb/m920x.c
> @@ -277,7 +277,6 @@ static int m920x_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[], int nu
>                         char *read = kmalloc(1, GFP_KERNEL);
>                         if (!read) {
>                                 ret = -ENOMEM;
> -                               kfree(read);
>                                 goto unlock;
>                         }
>  
> -- 
> 2.7.4
>