linux-kernel - Re: [REGRESSION] Missing IRQ via amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hy1zxrxw4.wl-tiwai@suse.de>
Date:   Fri, 22 Apr 2022 16:33:15 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Thorsten Leemhuis <regressions@...mhuis.info>
Cc:     Takashi Iwai <tiwai@...e.de>,
        Shreeya Patel <shreeya.patel@...labora.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        regressions@...ts.linux.dev,
        Mario Limonciello <mario.limonciello@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [REGRESSION] Missing IRQ via amd_gpio

On Fri, 22 Apr 2022 16:17:36 +0200,
Thorsten Leemhuis wrote:
> 
> Hi Takashi! Thx for CCing the regression list.
> 
> On 22.04.22 15:03, Takashi Iwai wrote:
> > Hi,
> > 
> > we received a bug report for 5.17.3 kernel showing a new error:
> > 
> >  amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
> > 
> > Not only an error message but in practice this leads to a missing IRQ
> > assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
> > 
> > As the error number (EPROBE_DEFER) indicates, this seems to be the
> > side-effect of the recent fix, the upstream commit 5467801f1fcb
> > ("gpio: Restrict usage of GPIO chip irq members before
> > initialization").  As far as I understand, the problem is in
> > acpi_gpiochip_request_interrupts() call that is called from
> > gpiochip_add_irqchip() itself.  Since it's called before the
> > initialized flag set, it always fails now.
> > 
> > Below is a temporary quick fix and it seems working.  But I'm not sure
> > whether I overlooked something obvious...
> 
> A patch that afaics will fix this hopefully should get merged really
> soon now:
> 
> https://lore.kernel.org/all/20220422131452.20757-1-mario.limonciello@amd.com/
> 
> See also v1:
> 
> https://lore.kernel.org/all/20220414025705.598-1-mario.limonciello@amd.com/

Thanks, good to know that we reached to the very same fix :)

So, feel free to take my tags to Mario's patch, if any:

Reviewed-by: Takashi Iwai <tiwai@...e.de>
Tested-by: Takashi Iwai <tiwai@...e.de>


Takashi