linux-kernel - Re: [PATCH 1/2] Revert "thermal/core: Deprecate changing cooling device state from userspace"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 16:50:02 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH 1/2] Revert "thermal/core: Deprecate changing cooling
 device state from userspace"

On Fri, Apr 22, 2022 at 4:11 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> This reverts commit a67a46af4ad6342378e332b7420c1d1a2818c53f.
>
> It has been reported the warning is annoying as the cooling device
> state is still needed on some production system.
>
> Meanwhile we provide a way to consolidate the thermal framework to
> prevent multiple actors acting on the cooling devices with conflicting
> decisions, let's revert this warning.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/thermal/thermal_sysfs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
> index f154bada2906..1c4aac8464a7 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -610,9 +610,6 @@ cur_state_store(struct device *dev, struct device_attribute *attr,
>         unsigned long state;
>         int result;
>
> -       dev_warn_once(&cdev->device,
> -                     "Setting cooling device state is deprecated\n");
> -
>         if (sscanf(buf, "%ld\n", &state) != 1)
>                 return -EINVAL;
>
> --

Applied along with the [2/2] as 5.18-rc material, thanks!