linux-kernel - Re: [PATCH 1/2] dt-bindings: thermal: sun8i-thermal: add binding for R329 THS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9525d336040d2fc89005d2923f0d8ee98597ac86.camel@aosc.io>
Date:   Sat, 23 Apr 2022 07:51:54 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Vasily Khoruzhick <anarsoul@...il.com>
Cc:     Yangtao Li <tiny.windzz@...il.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        arm-linux <linux-arm-kernel@...ts.infradead.org>,
        linux-sunxi@...ts.linux.dev,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: sun8i-thermal: add binding
 for R329 THS

在 2022-04-22星期五的 11:44 -0700，Vasily Khoruzhick写道：
> On Fri, Apr 22, 2022 at 9:12 AM <icenowy@...look.com> wrote:
> > 
> > From: Icenowy Zheng <icenowy@...c.io>
> > 
> > R329 has a thermal sensor controller that has only one sensor, and
> > the
> > structure of it is like the H6 one.
> > 
> > Add device tree binding for it.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> > ---
> >  .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml  | 3
> > +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-
> > ths.yaml
> > b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-
> > ths.yaml
> > index 6e0b110153b0..87b4103e0a5f 100644
> > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-
> > a83t-ths.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-
> > a83t-ths.yaml
> > @@ -20,6 +20,7 @@ properties:
> >        - allwinner,sun50i-a100-ths
> >        - allwinner,sun50i-h5-ths
> >        - allwinner,sun50i-h6-ths
> > +      - allwinner,sun50i-r329-ths
> > 
> >    clocks:
> >      minItems: 1
> > @@ -63,6 +64,7 @@ allOf:
> >              enum:
> >                - allwinner,sun50i-a100-ths
> >                - allwinner,sun50i-h6-ths
> > +              - allwinner,sun50i-r329-ths
> > 
> >      then:
> >        properties:
> > @@ -85,6 +87,7 @@ allOf:
> >          compatible:
> >            contains:
> >              const: allwinner,sun8i-h3-ths
> > +            const: allwinner,sun8i-r329-ths
> > 
> >      then:
> >        properties:
> 
> There's also a check at line #99 that requires clock, clock-names and
> resets properties for thermal sensors in other Allwinner SoCs. Are
> these not required for r329?

Thanks for this tip, I will add R329 to this check in the next
revision.

> 
> Also are you planning to add a node for thermal sensor to r329 dtsi?
> 
> 
> > --
> > 2.35.1
> >