linux-kernel - Re: iwlwifi: iwl-dbg: Use del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165069558761.20094.13183188216260268209.kvalo@kernel.org>
Date:   Sat, 23 Apr 2022 06:33:22 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-wireless@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Gregory Greenman <gregory.greenman@...el.com>
Subject: Re: iwlwifi: iwl-dbg: Use del_timer_sync() before freeing

Guenter Roeck <linux@...ck-us.net> wrote:

> In Chrome OS, a large number of crashes is observed due to corrupted timer
> lists. Steven Rostedt pointed out that this usually happens when a timer
> is freed while still active, and that the problem is often triggered
> by code calling del_timer() instead of del_timer_sync() just before
> freeing.
> 
> Steven also identified the iwlwifi driver as one of the possible culprits
> since it does exactly that.
> 
> Reported-by: Steven Rostedt <rostedt@...dmis.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Gregory Greenman <gregory.greenman@...el.com>
> Fixes: 60e8abd9d3e91 ("iwlwifi: dbg_ini: add periodic trigger new API support")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> Acked-by: Gregory Greenman <gregory.greenman@...el.com>
> Tested-by: Sedat Dilek <sedat.dilek@...il.com> # Linux v5.17.3-rc1 and Debian LLVM-14

Patch applied to wireless.git, thanks.

7635a1ad8d92 iwlwifi: iwl-dbg: Use del_timer_sync() before freeing

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220411154210.1870008-1-linux@roeck-us.net/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches