linux-kernel - Re: [PATCH 1/6] dt-bindings: ti,sci: Add ti,ctx-memory-region property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 14:10:52 -0500
From:   Dave Gerlach <d-gerlach@...com>
To:     Andrew Davis <afd@...com>, Rob Herring <robh+dt@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Tero Kristo <kristo@...nel.org>, Nishanth Menon <nm@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 1/6] dt-bindings: ti,sci: Add ti,ctx-memory-region
 property

Hi,

On 4/22/22 14:02, Andrew Davis wrote:
> On 4/21/22 3:36 PM, Dave Gerlach wrote:
>> Add documentation for the ti,ctx-memory-region property which is a
>> phandle to a reserved-memory carveout to be used by the ti_sci driver
>> storage of low power mode memory context. This is optional for normal
>> system operation but required to enabled suspend-to-mem usage of Deep
>> Sleep state.
>>
>> Signed-off-by: Dave Gerlach <d-gerlach@...com>
>> ---
>>   .../devicetree/bindings/arm/keystone/ti,sci.yaml         | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index 34f5f877d444..ec88aa88a2a0 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -61,6 +61,15 @@ properties:
>>     mboxes:
>>       minItems: 2
>>   
>> +  ti,ctx-memory-region:
>> +    description:
>> +      Phandle to the reserved memory node to be associated with the
>> +      ti-sci device, to be used for saving low power context. The
>> +      reserved memory node should be a carveout node, and should
>> +      be defined as per the bindings in
>> +      Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +
> 
> 
> Why does this have to be yet another reserved carveout region,
> should be dynamically allocated.
> 

This must be a fixed address in order to support other low power modes
which have not yet been introduced.

Regards,
Dave

> Andrew
> 
> 
>>     ti,system-reboot-controller:
>>       description: Determines If system reboot can be triggered by SoC reboot
>>       type: boolean