linux-kernel - Re: [PATCH] hwmon: (aquacomputer_d5next) Add support for Aquacomputer Farbwerk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220423163422.GA3964519@roeck-us.net>
Date:   Sat, 23 Apr 2022 09:34:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Aleksa Savic <savicaleksa83@...il.com>
Cc:     linux-hwmon@...r.kernel.org, Jack Doan <me@...kdoan.com>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Add support for
 Aquacomputer Farbwerk

On Sat, Apr 23, 2022 at 06:23:46PM +0200, Aleksa Savic wrote:
[ ... ]
> > > +	case USB_PRODUCT_ID_FARBWERK:
> > > +		priv->kind = farbwerk;
> > > +
> > 
> > 
> > Any special reason for this empty line ? It seems kind of random.
> > 
> > Guenter
> > 
> 
> That's how code in other cases of that switch is formatted (not visible
> from this patch directly), setting priv->kind and then the appropriate
> labels.
> 
Ah, ok. Looks odd here, but makes sense.

Thanks,
Guenter