linux-kernel - Re: [fs/pipe] 5a519c8fe4: WARNING:at_mm/page_alloc.c:#__alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wgBH+11vHDEKaPmDeVQ557mSruEXmEwBThACz3Xx-pvKA@mail.gmail.com>
Date:   Sat, 23 Apr 2022 14:02:36 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Andrei Vagin <avagin@...il.com>
Cc:     kernel test robot <oliver.sang@...el.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        kernel test robot <lkp@...el.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Pavel Emelyanov <ovzxemul@...il.com>
Subject: Re: [fs/pipe] 5a519c8fe4: WARNING:at_mm/page_alloc.c:#__alloc_pages

On Sat, Apr 23, 2022 at 1:23 PM Andrei Vagin <avagin@...il.com> wrote:
>
> vmsplice & splice  is the best. /proc/pid/mem is 30% slower.
> process_vm_readv is 20% slower.

Hmm.

I wonder how much low-hanging fruit there would be to optimize there.

Because process_vm_readv() in particular is pretty much _designed_ for
what you do, so it would be much nicer to basically work on that being
optimal, rather than doing vmsplice hackery.

(And yes, vmsplice is designed for efficient copies from the VM too,
of course, but that "limited to kernel pipe buffer" part is arguably
even more fundamental to it)

            Linus