linux-kernel - Re: [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220423015354.6558BC385A0@smtp.kernel.org>
Date:   Fri, 22 Apr 2022 18:53:52 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver

Quoting Bjorn Andersson (2022-04-22 16:00:13)
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> new file mode 100644
> index 000000000000..16bfe62efca2
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -0,0 +1,7451 @@
[...]
> +static struct clk_branch gcc_video_vcodec_throttle_clk = {
> +       .halt_reg = 0x28020,
> +       .halt_check = BRANCH_HALT_SKIP,
> +       .hwcg_reg = 0x28020,
> +       .hwcg_bit = 1,
> +       .clkr = {
> +               .enable_reg = 0x28020,
> +               .enable_mask = BIT(0),
> +               .hw.init = &(struct clk_init_data){

The clk_init_data can be const too, right?

> +                       .name = "gcc_video_vcodec_throttle_clk",
> +                       .ops = &clk_branch2_ops,
> +               },
> +       },
> +};