linux-kernel - Re: [Patch net-next] net: phy: LAN937x: add interrupt support for link detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <720895c7aca0828b8c9ed28608b21897a2e68b3e.camel@microchip.com>
Date:   Sun, 24 Apr 2022 10:15:58 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <andrew@...n.ch>
CC:     <linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <linux@...linux.org.uk>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <hkallweit1@...il.com>
Subject: Re: [Patch net-next] net: phy: LAN937x: add interrupt support for
 link detection

On Sat, 2022-04-23 at 17:59 +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Sat, Apr 23, 2022 at 09:17:27PM +0530, Arun Ramadoss wrote:
> > Added the config_intr and handle_interrupt for the LAN937x phy
> > which is
> > same as the LAN87xx phy.
> > 
> > Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> While looking at the code, i noticed LAN87XX has PHY_POLL_CABLE_TEST
> where as LAN937X does not. Is this correct?
> 
>     Andrew
Yes Andrew, When I added the LAN937x support in the below patch I added
the call back for the cable_test_start and cable_test_get_status and
forgot to add the PHY_POLL_CABLE_TEST flag.

https://patchwork.kernel.org/project/netdevbpf/patch/20220304094401.31375-6-arun.ramadoss@microchip.com/

I initially posted the patch for adding flag in net-next, but you have
suggested to me sent the bug fix patch for this. I sent the bug fix
patch for adding the flag. 

https://patchwork.kernel.org/project/netdevbpf/patch/20220413071409.13530-1-arun.ramadoss@microchip.com/