linux-kernel - Re: [PATCH v2] NFC: nfcmrvl: fix error check return value of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c990d0be-884c-2ae9-6161-ef50c89b00dc@linaro.org>
Date:   Sun, 24 Apr 2022 12:46:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     cgel.zte@...il.com, kuba@...nel.org
Cc:     cuissard@...vell.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, lv.ruyi@....com.cn,
        netdev@...r.kernel.org, sameo@...ux.intel.com,
        yashsri421@...il.com, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH v2] NFC: nfcmrvl: fix error check return value of
 irq_of_parse_and_map()

On 24/04/2022 04:57, cgel.zte@...il.com wrote:
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
> 
> Fixes: b5b3e23e4cac ("NFC: nfcmrvl: add i2c driver")
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---
> v2: don't print ret, and return -EINVAL rather than 0
> ---
>  drivers/nfc/nfcmrvl/i2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

How about Jakub's idea of squashing here fix for SPI (correcting my
patch) with additional Fixes tag?

Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")

Best regards,
Krzysztof