linux-kernel - Re: [PATCH] media: ov7670: remove ov7670_power_off from ov7670

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmV9heuEM+zpaE+x@pendragon.ideasonboard.com>
Date:   Sun, 24 Apr 2022 19:40:37 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
        Dongliang Mu <mudongliangabcd@...il.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: ov7670: remove ov7670_power_off from ov7670_remove

Hi Dongliang,

Thank you for the patch.

On Fri, Apr 22, 2022 at 04:54:05PM +0800, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@...il.com>
> 
> In ov7670_probe, it always invokes ov7670_power_off() no matter
> the execution is successful or failed. So we cannot invoke it
> agiain in ov7670_remove().
> 
> Fix this by removing ov7670_power_off from ov7670_remove.
> 
> Fixes: 030f9f682e66 ("media: ov7670: control clock along with power")

ov7670_power_off() is a no-op if power is already off. What does this
fix ?

> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> ---
>  drivers/media/i2c/ov7670.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
> index 196746423116..1be2c0e5bdc1 100644
> --- a/drivers/media/i2c/ov7670.c
> +++ b/drivers/media/i2c/ov7670.c
> @@ -2017,7 +2017,6 @@ static int ov7670_remove(struct i2c_client *client)
>  	v4l2_async_unregister_subdev(sd);
>  	v4l2_ctrl_handler_free(&info->hdl);
>  	media_entity_cleanup(&info->sd.entity);
> -	ov7670_power_off(sd);
>  	return 0;
>  }
>  

-- 
Regards,

Laurent Pinchart