linux-kernel - Re: [PATCH V4 3/7] iio: adc: Fine tune the scale calibration values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220424180147.02d3c8ca@jic23-huawei>
Date:   Sun, 24 Apr 2022 18:01:47 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cixi Geng <gengcixi@...il.com>
Cc:     lars@...afoo.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, orsonzhai@...il.com,
        baolin.wang7@...il.com, zhang.lyra@...il.com,
        yuming.zhu1@...soc.com, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 3/7] iio: adc: Fine tune the scale calibration values

On Tue, 19 Apr 2022 22:24:54 +0800
Cixi Geng <gengcixi@...il.com> wrote:

> From: Cixi Geng <cixi.geng1@...soc.com>
> 
> Small adjustment the scale calibration value for the sc2731,
> use new name sc2731_[big|small]_scale_graph_calib, and remove
> the origin [big|small]_scale_graph_calib struct for unused.
> 
> Fixes: 8ba0dbfd07a35 (iio: adc: sc27xx: Add ADC scale calibration)
No blank line here.
> 
> Signed-off-by: Cixi Geng <cixi.geng1@...soc.com>
> ---
>  drivers/iio/adc/sc27xx_adc.c | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index aee076c8e2b1..24211d2a71b1 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -103,14 +103,17 @@ static struct sc27xx_adc_linear_graph small_scale_graph = {
>  	100, 341,
>  };
>  
> -static const struct sc27xx_adc_linear_graph big_scale_graph_calib = {
> -	4200, 856,
> -	3600, 733,
> +/*
> + * Add the sc2731_[big|small]_scale_graph_calib for sc2731 pmic.
> + */

Why Add?

Given the variable naming conveys this anyway, I would drop the comment entirely.

> +static const struct sc27xx_adc_linear_graph sc2731_big_scale_graph_calib = {
> +	4200, 850,
> +	3600, 728,
>  };
>  
> -static const struct sc27xx_adc_linear_graph small_scale_graph_calib = {
> -	1000, 833,
> -	100, 80,
> +static const struct sc27xx_adc_linear_graph sc2731_small_scale_graph_calib = {
> +	1000, 838,
> +	100, 84,
>  };
>  
>  static int sc27xx_adc_get_calib_data(u32 calib_data, int calib_adc)
> @@ -130,11 +133,11 @@ static int sc27xx_adc_scale_calibration(struct sc27xx_adc_data *data,
>  	size_t len;
>  
>  	if (big_scale) {
> -		calib_graph = &big_scale_graph_calib;
> +		calib_graph = &sc2731_big_scale_graph_calib;
>  		graph = &big_scale_graph;
>  		cell_name = "big_scale_calib";
>  	} else {
> -		calib_graph = &small_scale_graph_calib;
> +		calib_graph = &sc2731_small_scale_graph_calib;
>  		graph = &small_scale_graph;
>  		cell_name = "small_scale_calib";
>  	}