linux-kernel - Re: [PATCH -next] ata: palmld: fix return value check in palmld_pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24916b73-15dc-1ab7-7d5d-532d177fecec@omp.ru>
Date:   Sun, 24 Apr 2022 19:55:11 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>
CC:     <damien.lemoal@...nsource.wdc.com>, <arnd@...db.de>,
        <b.zolnierkie@...sung.com>, <robert.jarzmik@...e.fr>
Subject: Re: [PATCH -next] ata: palmld: fix return value check in
 palmld_pata_probe()

Hello!

   You should CC: me on the PATA driver patches, not Bart -- he no longer maintains
the PATA drivers.

On 4/24/22 12:34 PM, Yang Yingliang wrote:

> If devm_platform_ioremap_resource() fails, it never return
> NULL pointer, replace the check with IS_ERR().
> 
> Fixes: 57bf0f5a162d ("ARM: pxa: use pdev resource for palmld mmio")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey