linux-kernel - Re: [PATCH v6 03/17] parisc: define get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f27c08b1-609a-a7f1-016f-8b782fa031b3@gmx.de>
Date:   Sun, 24 Apr 2022 20:35:10 +0200
From:   Helge Deller <deller@....de>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        tglx@...utronix.de, arnd@...db.de
Subject: Re: [PATCH v6 03/17] parisc: define get_cycles macro for
 arch-override

On 4/23/22 23:26, Jason A. Donenfeld wrote:
> PA-RISC defines a get_cycles() function, but it forgot to do the usual
> `#define get_cycles get_cycles` dance, making it impossible for generic
> code to see if an arch-specific function was defined.
>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Helge Deller <deller@....de>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Acked-by: Helge Deller <deller@....de> # parisc

Thank you!
Helge

> ---
>  arch/parisc/include/asm/timex.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/parisc/include/asm/timex.h b/arch/parisc/include/asm/timex.h
> index 06b510f8172e..b4622cb06a75 100644
> --- a/arch/parisc/include/asm/timex.h
> +++ b/arch/parisc/include/asm/timex.h
> @@ -13,9 +13,10 @@
>
>  typedef unsigned long cycles_t;
>
> -static inline cycles_t get_cycles (void)
> +static inline cycles_t get_cycles(void)
>  {
>  	return mfctl(16);
>  }
> +#define get_cycles get_cycles
>
>  #endif