lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Apr 2022 22:04:10 +0300 From: Dmitry Osipenko <dmitry.osipenko@...labora.com> To: David Airlie <airlied@...ux.ie>, Gerd Hoffmann <kraxel@...hat.com>, Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, Daniel Vetter <daniel@...ll.ch>, Daniel Almeida <daniel.almeida@...labora.com>, Gert Wollny <gert.wollny@...labora.com>, Gustavo Padovan <gustavo.padovan@...labora.com>, Daniel Stone <daniel@...ishbar.org>, Tomeu Vizoso <tomeu.vizoso@...labora.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>, Steven Price <steven.price@....com>, Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>, Rob Clark <robdclark@...il.com>, Emil Velikov <emil.l.velikov@...il.com>, Robin Murphy <robin.murphy@....com>, Qiang Yu <yuq825@...il.com>, Sumit Semwal <sumit.semwal@...aro.org>, Christian König <christian.koenig@....com> Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, Dmitry Osipenko <digetx@...il.com>, Dmitry Osipenko <dmitry.osipenko@...labora.com> Subject: [PATCH v5 03/17] drm/virtio: Check whether transferred 2D BO is shmem Transferred 2D BO always must be a shmem BO. Add check for that to prevent NULL dereference if userspace passes a VRAM BO. Cc: stable@...r.kernel.org Reviewed-by: Emil Velikov <emil.l.velikov@...il.com> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com> --- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index 7c052efe8836..2edf31806b74 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -595,7 +595,7 @@ void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev, bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev); struct virtio_gpu_object_shmem *shmem = to_virtio_gpu_shmem(bo); - if (use_dma_api) + if (virtio_gpu_is_shmem(bo) && use_dma_api) dma_sync_sgtable_for_device(vgdev->vdev->dev.parent, shmem->pages, DMA_TO_DEVICE); -- 2.35.1
Powered by blists - more mailing lists