linux-kernel - Re: [PATCH] sched/core: Skip sched_core_fork/free() when core sched is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 03:23:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cruz Zhao <CruzZhao@...ux.alibaba.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        akpm@...ux-foundation.org, tglx@...utronix.de, luto@...nel.org,
        legion@...nel.org, fenghua.yu@...el.com, david@...hat.com,
        bristot@...hat.com, bigeasy@...utronix.de, ebiederm@...ssion.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/core: Skip sched_core_fork/free() when core sched
 is disabled

Hi Cruz,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on hnaz-mm/master linus/master v5.18-rc3 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Cruz-Zhao/sched-core-Skip-sched_core_fork-free-when-core-sched-is-disabled/20220425-003934
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a658353167bf2ea6052cee071dbcc13e0f229dc9
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20220425/202204250352.INhpElgh-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/211b98683083c1f71c1821b89877743bd1a4cc99
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cruz-Zhao/sched-core-Skip-sched_core_fork-free-when-core-sched-is-disabled/20220425-003934
        git checkout 211b98683083c1f71c1821b89877743bd1a4cc99
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=ia64 prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
   scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
   scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
   In file included from include/linux/sched/signal.h:7,
                    from arch/ia64/kernel/asm-offsets.c:10:
>> include/linux/sched.h:2400:1: warning: data definition has no type or storage class
    2400 | DECLARE_STATIC_KEY_FALSE(__sched_core_enabled);
         | ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/sched.h:2400:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
>> include/linux/sched.h:2400:1: warning: parameter names (without types) in function declaration
   include/linux/sched.h: In function 'sched_core_disabled':
>> include/linux/sched.h:2403:17: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
    2403 |         return !static_branch_unlikely(&__sched_core_enabled);
         |                 ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/sched.h:2403:41: error: '__sched_core_enabled' undeclared (first use in this function); did you mean 'sched_core_disabled'?
    2403 |         return !static_branch_unlikely(&__sched_core_enabled);
         |                                         ^~~~~~~~~~~~~~~~~~~~
         |                                         sched_core_disabled
   include/linux/sched.h:2403:41: note: each undeclared identifier is reported only once for each function it appears in
   arch/ia64/kernel/asm-offsets.c: At top level:
   arch/ia64/kernel/asm-offsets.c:23:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
      23 | void foo(void)
         |      ^~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:120: arch/ia64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1194: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:219: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +2400 include/linux/sched.h

  2394	
  2395	#ifdef CONFIG_SCHED_CORE
  2396	extern void sched_core_free(struct task_struct *tsk);
  2397	extern void sched_core_fork(struct task_struct *p);
  2398	extern int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
  2399					unsigned long uaddr);
> 2400	DECLARE_STATIC_KEY_FALSE(__sched_core_enabled);
  2401	static inline bool sched_core_disabled(void)
  2402	{
> 2403		return !static_branch_unlikely(&__sched_core_enabled);
  2404	}
  2405	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp