linux-kernel - Re: [PATCH] irqchip/sun6i-r: Use NULL for chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Apr 2022 21:50:20 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Samuel Holland <samuel@...lland.org>
Cc:     Samuel Holland <samuel@...lland.org>,
        kernel test robot <lkp@...el.com>,
        Chen-Yu Tsai <wens@...e.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] irqchip/sun6i-r: Use NULL for chip_data

Dne nedelja, 24. april 2022 ob 19:39:51 CEST je Samuel Holland napisal(a):
> sparse complains about using an integer as a NULL pointer.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Samuel Holland <samuel@...lland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
> 
>  drivers/irqchip/irq-sun6i-r.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
> index 4cd3e533740b..a01e44049415 100644
> --- a/drivers/irqchip/irq-sun6i-r.c
> +++ b/drivers/irqchip/irq-sun6i-r.c
> @@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain 
*domain,
>  	for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
>  		if (hwirq == nmi_hwirq) {
>  			irq_domain_set_hwirq_and_chip(domain, virq, 
hwirq,
> -						      
&sun6i_r_intc_nmi_chip, 0);
> +						      
&sun6i_r_intc_nmi_chip,
> +						      NULL);
>  			irq_set_handler(virq, 
handle_fasteoi_ack_irq);
>  		} else {
>  			irq_domain_set_hwirq_and_chip(domain, virq, 
hwirq,
> -						      
&sun6i_r_intc_wakeup_chip, 0);
> +						      
&sun6i_r_intc_wakeup_chip,
> +						      NULL);
>  		}
>  	}
>  
> -- 
> 2.35.1
> 
>