linux-kernel - Re: [PATCH] perf sched: simplify if-if to if-else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Apr 2022 21:01:36 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        kael_w@...h.net
Subject: Re: [PATCH] perf sched: simplify if-if to if-else

Em Sun, Apr 24, 2022 at 05:07:27PM +0800, Wan Jiabing escreveu:
> Use if and else instead of if(A) and if (!A).

I'm now looking for a brown paper bag... There is some hope, but I'm not
in a mood, will check tomorrow, but certainly this should go in, thanks!

- Arnaldo
 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  tools/perf/builtin-sched.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 646bd938927a..66f8e9318123 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -3070,8 +3070,7 @@ static int perf_sched__timehist(struct perf_sched *sched)
>  	/* summary_only implies summary option, but don't overwrite summary if set */
>  	if (sched->summary_only)
>  		sched->summary = sched->summary_only;
> -
> -	if (!sched->summary_only)
> +	else
>  		timehist_header(sched);
>  
>  	err = perf_session__process_events(session);
> -- 
> 2.35.1

-- 

- Arnaldo