linux-kernel - Re: [PATCH] spi: rockchip: fix missing error on unsupported SPI_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 18:24:54 +0100
From:   Mark Brown <broonie@...nel.org>
To:     luca.ceresoli@...tlin.com, linux-spi@...r.kernel.org
Cc:     chris.ruehl@...ys.com.hk, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        heiko@...ech.de
Subject: Re: [PATCH] spi: rockchip: fix missing error on unsupported SPI_CS_HIGH

On Thu, 21 Apr 2022 23:32:51 +0200, Luca Ceresoli wrote:
> The hardware (except for the ROCKCHIP_SPI_VER2_TYPE2 version) does not
> support active-high native chip selects. However if such a CS is configured
> the core does not error as it normally should, because the
> 'ctlr->use_gpio_descriptors = true' line in rockchip_spi_probe() makes the
> core set SPI_CS_HIGH in ctlr->mode_bits.
> 
> In such a case the spi-rockchip driver operates normally but produces an
> active-low chip select signal without notice.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: rockchip: fix missing error on unsupported SPI_CS_HIGH
      commit: d5d933f09ac326aebad85bfb787cc786ad477711

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark