linux-kernel - Re: [PATCH v3] dt-bindings: gnss: Rewrite Mediatek bindings in YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ede50fc5-177d-3821-1f47-7297a7a8ebf3@linaro.org>
Date:   Mon, 25 Apr 2022 19:49:18 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Johan Hovold <johan@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: gnss: Rewrite Mediatek bindings in YAML

On 25/04/2022 15:29, Linus Walleij wrote:
> This rewrites the Mediatek GNSS bindings in YAML.
> 
> Cc: devicetree@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v2->v3:
> - Add the missed gnss-fix-gpios.
> - Move allOf to right before the properties.
> - Keep the description on timepulse-gpios because it documents
>   which pins are used on this chip.
> ChangeLog v1->v2:
> - New patch since Krzysztof pointed out there is really just
>   one more binding to convert, so why not.
> ---
>  .../devicetree/bindings/gnss/mediatek.txt     | 35 -----------
>  .../devicetree/bindings/gnss/mediatek.yaml    | 59 +++++++++++++++++++

Bindings look good, just the filename should be probably more specific,
to match the model... but then who is the vendor? mediatek,pa6h.yaml or
mediatek,globaltop-pa6h.yaml? I sincerely do not know, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof