linux-kernel - Re: [PATCH] Input: aiptek - remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Apr 2022 21:01:56 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] Input: aiptek - remove redundant assignment to variable
 ret

On Mon, Apr 18, 2022 at 03:24:57PM +0100, Colin Ian King wrote:
> Variable ret is being assigned a value that is never read, it is
> being re-assigned again in either path of the if statement. The
> assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> Although the value stored to 'ret' is used in the enclosing expression,
> the value is never actually read from 'ret' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Applied, thank you.

-- 
Dmitry