linux-kernel - Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n50fs1fFQcwMCq_x_UG8ZJKprjcYKwcy1+1ckD--XE28+g@mail.gmail.com>
Date:   Mon, 25 Apr 2022 13:10:29 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     cgel.zte@...il.com, robdclark@...il.com, sean@...rly.run
Cc:     quic_abhinavk@...cinc.com, airlied@...ux.ie, daniel@...ll.ch,
        dmitry.baryshkov@...aro.org, bjorn.andersson@...aro.org,
        angelogioacchino.delregno@...ainline.org, tiny.windzz@...il.com,
        architt@...eaurora.org, jsanka@...eaurora.org,
        skolluku@...eaurora.org, ryadav@...eaurora.org,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

Quoting cgel.zte@...il.com (2022-04-25 02:09:47)
> From: Lv Ruyi <lv.ruyi@....com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return a negative value anyhow, so never enter this conditional branch.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---

Question still stands why we can't use platform device APIs.

Reviewed-by: Stephen Boyd <swboyd@...omium.org>