linux-kernel - Re: [PATCH v2 1/4] dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdajs2TUe-E+y6RaroSc1bdpHwUOhmZ8FgPrdFj8g4L1Aw@mail.gmail.com>
Date:   Mon, 25 Apr 2022 22:26:18 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sean Anderson <sean.anderson@...o.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        Jules Maselbas <jmaselbas@...ray.eu>,
        Felipe Balbi <balbi@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator

On Mon, Apr 25, 2022 at 7:14 PM Sean Anderson <sean.anderson@...o.com> wrote:

> The vbus-regulator property was never actually read from the device tree.
> Introduce a new property vbus-supply to represent the regulator powering
> the VBUS when acting as an A-Device. This supply will be enabled and
> disabled as necessary. Note that this is different from vbus-regulator,
> which represented the available current available to draw from VBUS in
> B-Device mode. Because no one was using vbus-regulator, remove it.
>
> Signed-off-by: Sean Anderson <sean.anderson@...o.com>
(...)
> +  vbus-supply:
> +    description: regulator supplying VBUS. It will be enabled and disabled
> +                 dynamically in OTG mode.

I would add a small text snippet like this: "If the regulator is controlled by a
GPIO line, this should be modeled as a regulator-fixed and referenced
by this supply" - it's helpful because otherwise people tend to start to
submit weird stuff like adding yet another GPIO for this.

Either way:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij