linux-kernel - Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8db5f7cc-dbad-3636-0fd2-7d6dc29ee409@linaro.org>
Date:   Mon, 25 Apr 2022 22:28:48 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Stephen Boyd <sboyd@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh@...nel.org>, Taniya Das <tdas@...eaurora.org>
Cc:     Ansuel Smith <ansuelsmth@...il.com>, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in
 compatible string

On 25/04/2022 21:32, Stephen Boyd wrote:
> Quoting Rob Herring (2022-04-25 06:35:27)
>> The compatible string should be 'qcom,gcc-apq8064', not
>> 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
>>
>> Cc: Ansuel Smith <ansuelsmth@...il.com>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> index 97936411b6b4..9910a3e033bb 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> @@ -25,7 +25,7 @@ description: |
>>  
>>  properties:
>>    compatible:
>> -    const: qcom,gcc-apq8084
>> +    const: qcom,gcc-apq8064
> 
> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
> simplify qcom,gcc-apq8064 Documentation") took the more than just the
> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
> the apq8064 file with the single compatible changed.

Good point, Rob's commit removes entirely qcom,gcc-apq8084 compatible,
which is and was used.

Probably the intention of that commit was to merge apq8064 and apq8084.
The first uses dt-bindings/clock/qcom,gcc-msm8960.h header for IDs. The
second has its own headers, added in mentioned commit.

I am not sure it is worth splitting this into two files. Adding here
enum for 8064 and 8084 should work fine.

Best regards,
Krzysztof