[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fUUeqimTKoO9PQbm4yDWXZtTqxWm9ZAsNt1=K5N1Rq_Lg@mail.gmail.com>
Date: Mon, 25 Apr 2022 13:59:03 -0700
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...hat.com>,
Michael Petlan <mpetlan@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...nel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
Song Liu <songliubraving@...com>,
Will Deacon <will@...nel.org>,
Mark Rutland <mark.rutland@....com>,
John Garry <john.garry@...wei.com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Leo Yan <leo.yan@...aro.org>,
Michael Ellerman <mpe@...erman.id.au>,
Heiko Carstens <hca@...ux.ibm.com>,
LKML <linux-kernel@...r.kernel.org>,
linux-perf-users@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
linux-s390@...r.kernel.org
Subject: Re: [PATCH 0/3] perf tools: Tidy up symbol end fixup (v3)
On Fri, Apr 15, 2022 at 5:40 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hello,
>
> This work is a follow-up of Ian's previous one at
> https://lore.kernel.org/all/20220412154817.2728324-1-irogers@google.com/
>
> Fixing up more symbol ends as introduced in:
> https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/
>
> it caused perf annotate to run into memory limits - every symbol holds
> all the disassembled code in the annotation, and so making symbols
> ends further away dramatically increased memory usage (40MB to >1GB).
>
> Modify the symbol end fixup logic so that special kernel cases aren't
> applied in the common case.
>
> v3 changes)
> * rename is_kernel to is_kallsyms
> * move the logic to generic function
> * remove arch-specific functions
>
> Thanks,
> Namhyung
Thanks Namhyung! The series:
Acked-by: Ian Rogers <irogers@...gle.com>
> Namhyung Kim (3):
> perf symbol: Pass is_kallsyms to symbols__fixup_end()
> perf symbol: Update symbols__fixup_end()
> perf symbol: Remove arch__symbols__fixup_end()
>
> tools/perf/arch/arm64/util/machine.c | 21 ---------------
> tools/perf/arch/powerpc/util/Build | 1 -
> tools/perf/arch/powerpc/util/machine.c | 25 -----------------
> tools/perf/arch/s390/util/machine.c | 16 -----------
> tools/perf/util/symbol-elf.c | 2 +-
> tools/perf/util/symbol.c | 37 +++++++++++++++++++-------
> tools/perf/util/symbol.h | 3 +--
> 7 files changed, 29 insertions(+), 76 deletions(-)
> delete mode 100644 tools/perf/arch/powerpc/util/machine.c
>
>
> base-commit: 41204da4c16071be9090940b18f566832d46becc
> --
> 2.36.0.rc0.470.gd361397f0d-goog
>
Powered by blists - more mailing lists