linux-kernel - Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1564e2b1-e205-aa44-6a30-38a5160b0ec3@linaro.org>
Date:   Tue, 26 Apr 2022 00:11:20 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>, cgel.zte@...il.com,
        quic_abhinavk@...cinc.com, sean@...rly.run
Cc:     robdclark@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        angelogioacchino.delregno@...labora.com,
        daniel.thompson@...aro.org, linmq006@...il.com,
        christophe.jaillet@...adoo.fr, lv.ruyi@....com.cn,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drm/msm/hdmi: fix error check return value of
 irq_of_parse_and_map()

On 25/04/2022 23:11, Stephen Boyd wrote:
> Quoting cgel.zte@...il.com (2022-04-25 02:18:31)
>> From: Lv Ruyi <lv.ruyi@....com.cn>
>>
>> The irq_of_parse_and_map() function returns 0 on failure, and does not
>> return a negative value anyhow, so never enter this conditional branch.
>>
>> Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains")
>> Reported-by: Zeal Robot <zealci@....com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
>> ---
> 
> This one fixes a commit that moved away from platform APIs!

The change was introduced in 2014 in the commit f6a8eaca0ea1 
("drm/msm/mdp5: use irqdomains"). I can suspect that at that time 
platform irq code wasn't fully compatible with IRQ domains.

> Reviewed-by: Stephen Boyd <swboyd@...omium.org>


-- 
With best wishes
Dmitry