linux-kernel - Re: [PATCH] drm/amd/display: fix if == else warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 17:55:35 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     "Liu, Zhan" <Zhan.Liu@....com>
Cc:     Guo Zhengkui <guozhengkui@...o.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Liu, Charlene" <Charlene.Liu@....com>,
        "Lei, Jun" <Jun.Lei@....com>,
        José Expósito <jose.exposito89@...il.com>,
        "open list:AMD DISPLAY CORE" <amd-gfx@...ts.freedesktop.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>,
        "zhengkui_guo@...look.com" <zhengkui_guo@...look.com>
Subject: Re: [PATCH] drm/amd/display: fix if == else warning

Applied.  Thanks!

Alex

On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan <Zhan.Liu@....com> wrote:
>
> [AMD Official Use Only - General]
>
> > -----Original Message-----
> > From: Guo Zhengkui <guozhengkui@...o.com>
> > Sent: 2022/April/24, Sunday 5:06 AM
> > To: Wentland, Harry <Harry.Wentland@....com>; Li, Sun peng (Leo)
> > <Sunpeng.Li@....com>; Siqueira, Rodrigo <Rodrigo.Siqueira@....com>;
> > Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian
> > <Christian.Koenig@....com>; Pan, Xinhui <Xinhui.Pan@....com>; David Airlie
> > <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>; Liu, Charlene
> > <Charlene.Liu@....com>; Lei, Jun <Jun.Lei@....com>; Guo Zhengkui
> > <guozhengkui@...o.com>; Liu, Zhan <Zhan.Liu@....com>; José Expósito
> > <jose.exposito89@...il.com>; open list:AMD DISPLAY CORE <amd-
> > gfx@...ts.freedesktop.org>; open list:DRM DRIVERS <dri-
> > devel@...ts.freedesktop.org>; open list <linux-kernel@...r.kernel.org>
> > Cc: zhengkui_guo@...look.com
> > Subject: [PATCH] drm/amd/display: fix if == else warning
> >
> > Fix the following coccicheck warning:
> >
> > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10:
> > WARNING: possible condition with no effect (if == else)
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
>
> Thanks a lot for fixing this warning.
>
> Reviewed-by: Zhan Liu <zhan.liu@....com>
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > index fe22530242d2..05b3fba9ccce 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
> >       } else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
> >                       addr->quad_part <= hwseq->uma_top.quad_part) {
> >               is_in_uma = true;
> > -     } else if (addr->quad_part == 0) {
> > -             is_in_uma = false;
> >       } else {
> >               is_in_uma = false;
> >       }
> > --
> > 2.20.1
>