linux-kernel - Re: [PATCH -next v5 4/5] arm64: mm: add support for page table check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ad261fc-4eb0-21f4-2f6b-11696cd5c1c3@arm.com>
Date:   Mon, 25 Apr 2022 11:11:46 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Tong Tiangen <tongtiangen@...wei.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-riscv@...ts.infradead.org,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Guohanjun <guohanjun@...wei.com>
Subject: Re: [PATCH -next v5 4/5] arm64: mm: add support for page table check



On 4/24/22 09:44, Tong Tiangen wrote:
> 
> 
> 在 2022/4/22 14:45, Anshuman Khandual 写道:
>> Please change the subject line as
>>
>> arm64/mm: Enable ARCH_SUPPORTS_PAGE_TABLE_CHECK
>>
>> OR
>>
>> arm64/mm: Subscribe ARCH_SUPPORTS_PAGE_TABLE_CHECK
>>
>> On 4/21/22 13:50, Tong Tiangen wrote:
>>> From: Kefeng Wang <wangkefeng.wang@...wei.com>
>>>
>>> As commit d283d422c6c4 ("x86: mm: add x86_64 support for page table
>>> check"), add some necessary page table check hooks into routines that
>>> modify user page tables.
>>
>> Please make the commit message comprehensive, which should include
>>
>> - Enabling ARCH_SUPPORTS_PAGE_TABLE_CHECK on arm64
>> - Adding all additional page table helpers required for PAGE_TABLE_CHECK
>> - Instrumenting existing page table helpers with page table check hooks
>>
> 
> Good suggestion, if i need to do a new version for some other reason i think it should be described more comprehensivel


This series needs revision to accommodate earlier comments.