linux-kernel - Re: [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4k2hso7y.wl-tiwai@suse.de>
Date:   Mon, 25 Apr 2022 07:53:37 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it

On Sun, 24 Apr 2022 22:59:45 +0200,
Colin Ian King wrote:
> 
> Pointer substream is being dereferenced on the assignment of pointer card
> before substream is being null checked with the macro PCM_RUNTIME_CHECK.
> Although PCM_RUNTIME_CHECK calls BUG_ON, it still is useful to perform the
> the pointer check before card is assigned.
> 
> Fixes: commit d4cfb30fce03 ("ALSA: pcm: Set per-card upper limit of PCM buffer allocations")
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks, applied with the correction of Fixes tag.


Takashi