linux-kernel - Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com>
Date:   Mon, 25 Apr 2022 09:10:17 +0200
From:   "Juan A." Suárez <jasuarez@...lia.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Emma Anholt <emma@...olt.net>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Melissa Wen <mwen@...lia.com>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote:
> In the unlikely event that pointer perfmon is null the WARN_ON return
> path
> occurs after the pointer has already been deferenced. Fix this by
> only
> dereferencing perfmon after it has been null checked.
> 

Good catch!

Reviewed-by: Juan A. Suarez <jasuarez@...lia.com>


	J.A.