lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Apr 2022 10:52:22 +0300 From: Mike Rapoport <rppt@...nel.org> To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Cc: Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@...nel.org>, Sean Christopherson <seanjc@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, Joerg Roedel <jroedel@...e.de>, Ard Biesheuvel <ardb@...nel.org>, Andi Kleen <ak@...ux.intel.com>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, David Rientjes <rientjes@...gle.com>, Vlastimil Babka <vbabka@...e.cz>, Tom Lendacky <thomas.lendacky@....com>, Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Paolo Bonzini <pbonzini@...hat.com>, Ingo Molnar <mingo@...hat.com>, Varad Gautam <varad.gautam@...e.com>, Dario Faggioli <dfaggioli@...e.com>, Dave Hansen <dave.hansen@...el.com>, Brijesh Singh <brijesh.singh@....com>, David Hildenbrand <david@...hat.com>, x86@...nel.org, linux-mm@...ck.org, linux-coco@...ts.linux.dev, linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv5 01/12] x86/boot/: Centralize __pa()/__va() definitions On Mon, Apr 25, 2022 at 06:39:23AM +0300, Kirill A. Shutemov wrote: > Replace multiple __pa()/__va() definitions with a single one in misc.h. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com> > --- > arch/x86/boot/compressed/ident_map_64.c | 8 -------- > arch/x86/boot/compressed/misc.h | 9 +++++++++ > arch/x86/boot/compressed/sev.c | 2 -- > 3 files changed, 9 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c > index f7213d0943b8..fe523ee1a19f 100644 > --- a/arch/x86/boot/compressed/ident_map_64.c > +++ b/arch/x86/boot/compressed/ident_map_64.c > @@ -8,14 +8,6 @@ > * Copyright (C) 2016 Kees Cook > */ > > -/* > - * Since we're dealing with identity mappings, physical and virtual > - * addresses are the same, so override these defines which are ultimately > - * used by the headers in misc.h. > - */ > -#define __pa(x) ((unsigned long)(x)) > -#define __va(x) ((void *)((unsigned long)(x))) > - > /* No PAGE_TABLE_ISOLATION support needed either: */ > #undef CONFIG_PAGE_TABLE_ISOLATION > > diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h > index ea71cf3d64e1..9f7154a30d37 100644 > --- a/arch/x86/boot/compressed/misc.h > +++ b/arch/x86/boot/compressed/misc.h > @@ -19,6 +19,15 @@ > /* cpu_feature_enabled() cannot be used this early */ > #define USE_EARLY_PGTABLE_L5 > > +/* > + * Boot stub deals with identity mappings, physical and virtual addresses are > + * the same, so override these defines. > + * > + * <asm/page.h> will not define them if they are already defined. > + */ > +#define __pa(x) ((unsigned long)(x)) > +#define __va(x) ((void *)((unsigned long)(x))) > + > #include <linux/linkage.h> > #include <linux/screen_info.h> > #include <linux/elf.h> > diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c > index 28bcf04c022e..4dcea0bc4fe4 100644 > --- a/arch/x86/boot/compressed/sev.c > +++ b/arch/x86/boot/compressed/sev.c > @@ -106,9 +106,7 @@ static enum es_result vc_read_mem(struct es_em_ctxt *ctxt, > } > > #undef __init > -#undef __pa > #define __init > -#define __pa(x) ((unsigned long)(x)) > > #define __BOOT_COMPRESSED > > -- > 2.35.1 > -- Sincerely yours, Mike.
Powered by blists - more mailing lists