linux-kernel - Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5175fe30-0449-ac5f-7e37-53c07adc433a@linaro.org>
Date:   Mon, 25 Apr 2022 09:53:43 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "allen-kh.cheng" <allen-kh.cheng@...iatek.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>, nfraprado@...labora.com
Cc:     Project_Global_Chrome_Upstream_Group@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        srv_heupstream@...iatek.com, Chen-Yu Tsai <wenst@...omium.org>,
        Ryder Lee <ryder.lee@...nel.org>
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to
 YAML

On 25/04/2022 09:37, allen-kh.cheng wrote:

>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> +    watchdog@...07000 {
>>> +        compatible = "mediatek,mt8183-wdt",
>>> +                     "mediatek,mt6589-wdt";
>>> +        mediatek,disable-extrst;
>>
>> Did you test your bindings? Does not look like. Please run
>> dt_binding_check (see writing-schema for instructions).
>>
> 
> Yes, I have run dt_binding_check.
> 
> But example is from original binding txt file.
> 
> Is it ok I can write a new expample?

Yes, please. Correct the example in the conversion so it is
reasonable/proper.


Best regards,
Krzysztof