[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <YmaMgPr8bM/0PFUi@kili>
Date: Mon, 25 Apr 2022 14:56:48 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Alasdair Kergon <agk@...hat.com>,
Mikulas Patocka <mpatocka@...hat.com>
Cc: Mike Snitzer <snitzer@...nel.org>, dm-devel@...hat.com,
Milan Broz <gmazyland@...il.com>, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH] dm integrity: fix error code in dm_integrity_ctr()
The "r" variable shadows an earlier "r" that has function scope. It
means that we accidentally return success instead of an error code.
Smatch has a warning for this:
drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
warn: missing error code 'r'
Fixes: 7eada909bfd7 ("dm: add integrity target")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
drivers/md/dm-integrity.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index 36ae30b73a6e..3d5a0ce123c9 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -4494,8 +4494,6 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned argc, char **argv)
}
if (should_write_sb) {
- int r;
-
init_journal(ic, 0, ic->journal_sections, 0);
r = dm_integrity_failed(ic);
if (unlikely(r)) {
--
2.35.1
Powered by blists - more mailing lists